Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(ci): always use python3 executable #9531

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix(ci): always use python3 executable #9531

wants to merge 1 commit into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Oct 4, 2021

On many (particularly older) systems, the python command can refer to python2 instead of python3. Therefore we change all python calls to python3 to prevent failures on some self-hosted runners.

Open in Gitpod

Vierkantor
Vierkantor approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly specifying python3 is an official recommendation of good practice in the Python world, so LGTM.

jcommelin
jcommelin approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 4, 2021
bors bot pushed a commit that referenced this pull request Oct 4, 2021
@gebner
fix(ci): always use python3 executable (#9531)
551c5b2 
On many (particularly older) systems, the `python` command can refer to `python2` instead of `python3`.  Therefore we change all `python` calls to `python3` to prevent failures on some self-hosted runners.
@fpvandoorn
Copy link
Member

It looks like the CI for this PR got canceled
bors r-

@fpvandoorn
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 4, 2021
@gebner
fix(ci): always use python3 executable (#9531)
f6c77be 
On many (particularly older) systems, the `python` command can refer to `python2` instead of `python3`.  Therefore we change all `python` calls to `python3` to prevent failures on some self-hosted runners.
@bors
Copy link

bors bot commented Oct 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(ci): always use python3 executable [Merged by Bors] - fix(ci): always use python3 executable Oct 4, 2021
@bors bors bot closed this Oct 4, 2021
@bors bors bot deleted the python3 branch October 4, 2021 15:09
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gebner @fpvandoorn @Vierkantor @jcommelin @eric-wieser