New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/normed_space/add_torsor_bases): barycentric coordinates are open maps (in finite dimensions over a complete field) #9543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocfnash
added
the
awaiting-review
The author would like community review of the PR
label
Oct 4, 2021
github-actions
bot
added
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
labels
Oct 4, 2021
ocfnash
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 6, 2021
ocfnash
force-pushed
the
barycentric_open
branch
from
October 6, 2021 08:06
058a30d
to
8b9e9e5
Compare
github-actions
bot
removed
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Oct 6, 2021
… are open maps (in finite dimensions over a complete field) Formalized as part of the Sphere Eversion project.
ocfnash
force-pushed
the
barycentric_open
branch
from
October 6, 2021 18:00
8b9e9e5
to
e24e5d6
Compare
github-actions
bot
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Oct 6, 2021
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
ocfnash
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Oct 6, 2021
ocfnash
commented
Oct 6, 2021
ocfnash
commented
Oct 6, 2021
let w : ι → k := λ j', if j' = i then x else 1-x, | ||
have hw : s.sum w = 1, { simp [hij, finset.sum_ite, finset.filter_insert, finset.filter_eq'], }, | ||
use s.affine_combination p w, | ||
simp only [barycentric_coord_apply_combination_of_mem h_ind h_tot hi hw, ite_eq_left_iff, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
simp only [barycentric_coord_apply_combination_of_mem h_ind h_tot hi hw, ite_eq_left_iff, |
ocfnash
commented
Oct 6, 2021
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 6, 2021
bors bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
… are open maps (in finite dimensions over a complete field) (#9543) Using the open mapping theorem with a one-dimensional codomain feels a bit ridiculous but I see no reason not to do so. Formalized as part of the Sphere Eversion project.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(analysis/normed_space/add_torsor_bases): barycentric coordinates are open maps (in finite dimensions over a complete field)
[Merged by Bors] - feat(analysis/normed_space/add_torsor_bases): barycentric coordinates are open maps (in finite dimensions over a complete field)
Oct 6, 2021
eric-wieser
added
the
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
label
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the open mapping theorem with a one-dimensional codomain feels a bit ridiculous but I see no reason not to do so.
Formalized as part of the Sphere Eversion project.