Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(algebra/floor): Add ceil as a field of floor_ring #9591

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - refactor(algebra/floor): Add ceil as a field of floor_ring #9591

wants to merge 12 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 7, 2021 •
edited by github-actions bot

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 7, 2021
@YaelDillies YaelDillies mentioned this pull request Oct 7, 2021
Closed
1 task
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 8, 2021
@github-actions github-actions bot removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Oct 14, 2021
@YaelDillies YaelDillies mentioned this pull request Oct 14, 2021
Closed
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 15, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 15, 2021
bors bot pushed a commit that referenced this pull request Oct 16, 2021
@YaelDillies
feat(algebra/floor): Floor and ceil of -a (#9715)
99b2d40 
This proves `floor_neg : ⌊-a⌋ = -⌈a⌉` and `ceil_neg : ⌈-a⌉ = -⌊a⌋` and uses them to remove explicit dependency on the definition of `int.ceil` in prevision of #9591. This also proves `⌊a + 1⌋ = ⌊a⌋ + 1` and variants.
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 16, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 17, 2021
@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Oct 17, 2021
Vierkantor
Vierkantor approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

bors d+

src/algebra/floor.lean Outdated Show resolved Hide resolved
src/algebra/floor.lean Show resolved Hide resolved
src/algebra/floor.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 18, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 18, 2021
@YaelDillies @Vierkantor
add calculation rules
eb1ed3d 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@YaelDillies
Copy link
Collaborator Author

Thanks!

bors merge

bors bot pushed a commit that referenced this pull request Oct 18, 2021
@YaelDillies
refactor(algebra/floor): Add ceil as a field of floor_ring (#9591)
80071d4 
This allows more control on definitional equality.
@bors
Copy link

bors bot commented Oct 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/floor): Add ceil as a field of floor_ring [Merged by Bors] - refactor(algebra/floor): Add ceil as a field of floor_ring Oct 18, 2021
@bors bors bot closed this Oct 18, 2021
@bors bors bot deleted the floor_ceil_gc branch October 18, 2021 17:55
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
@YaelDillies @ericrbg
refactor(algebra/floor): Add ceil as a field of floor_ring (#9591)
a85f904 
This allows more control on definitional equality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @Vierkantor @eric-wieser