Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/floor): Floor semirings #9592

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(algebra/floor): Floor semirings #9592

wants to merge 11 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 7, 2021 •
edited by github-actions bot

A floor semiring is a semiring equipped with a floor and a ceil function.

This allows generalizing nat.floor and nat.ceil to semirings, most notably nnreal.

Open in Gitpod

@YaelDillies YaelDillies added the WIP Work in progress label Oct 7, 2021
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Oct 7, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 17, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 19, 2021
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Oct 19, 2021
fpvandoorn
fpvandoorn approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

src/algebra/floor.lean Outdated Show resolved Hide resolved
src/algebra/floor.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 21, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 21, 2021
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 21, 2021
@YaelDillies
feat(algebra/floor): Floor semirings (#9592)
49b3488 
A floor semiring is a semiring equipped with a `floor` and a `ceil` function.
@bors
Copy link

bors bot commented Oct 21, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 21, 2021
@YaelDillies
feat(algebra/floor): Floor semirings (#9592)
21993a0 
A floor semiring is a semiring equipped with a `floor` and a `ceil` function.
@bors
Copy link

bors bot commented Oct 21, 2021

Build failed:

@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 22, 2021
@YaelDillies
feat(algebra/floor): Floor semirings (#9592)
03ba4cc 
A floor semiring is a semiring equipped with a `floor` and a `ceil` function.
@bryangingechen
Copy link
Collaborator

This was merged, but bors crashed.

@bryangingechen bryangingechen changed the title feat(algebra/floor): Floor semirings [Merged by Bors] - feat(algebra/floor): Floor semirings Oct 22, 2021
@YaelDillies YaelDillies deleted the floorsemiring branch October 22, 2021 22:49
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
@YaelDillies @ericrbg
feat(algebra/floor): Floor semirings (#9592)
e987bbb 
A floor semiring is a semiring equipped with a `floor` and a `ceil` function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @bryangingechen @fpvandoorn @eric-wieser