[Merged by Bors] - feat(group_theory/subgroup/basic): a new to_additive lemma, and remove a by hand proof #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a lemma generated by to_additive
alexjbest
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
…e a by hand proof (#9594) I needed `add_subgroup.smul_mem` which didn't seem to exist, and noticed that the `add_subgroup.gsmul_mem` version is proved by hand while to_additive generates it fine (now?)
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
…e a by hand proof (#9594) I needed `add_subgroup.smul_mem` which didn't seem to exist, and noticed that the `add_subgroup.gsmul_mem` version is proved by hand while to_additive generates it fine (now?)
|
Build failed (retrying...): |
eric-wieser
reviewed
Oct 7, 2021
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
…e a by hand proof (#9594) I needed `add_subgroup.smul_mem` which didn't seem to exist, and noticed that the `add_subgroup.gsmul_mem` version is proved by hand while to_additive generates it fine (now?)
|
bors r- |
|
Canceled. |
|
bors d+ Thanks! |
|
✌️ alexjbest can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
…e a by hand proof (#9594) I needed `add_subgroup.smul_mem` which didn't seem to exist, and noticed that the `add_subgroup.gsmul_mem` version is proved by hand while to_additive generates it fine (now?)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed
add_subgroup.smul_memwhich didn't seem to exist, and noticed that theadd_subgroup.gsmul_memversion is proved by hand while to_additive generates it fine (now?)