[Merged by Bors] - feat(data/finset): add finset.erase_none
#9630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
needs-documentation
Closed
1 task
github-actions
bot
removed
the
awaiting-CI
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
* move `option.to_finset` and `finset.insert_none` to a new file `data.finset.option`; redefine the latter in terms of `finset.cons`; * define `finset.erase_none`, prove lemmas about it; * add `finset.prod_cons`, `finset.sum_cons`, `finset.coe_cons`, `finset.cons_subset_cons`, `finset.card_cons`; * add `finset.subtype_mono` and `finset.bUnion_congr`; * add `set.insert_subset_insert_iff`; * add `@[simp]` to `finset.map_subset_map`; * upgrade `finset.map_embedding` to an `order_embedding`; * add `@[simps]` to `equiv.option_is_some_equiv` and `function.embedding.some`; * golf some proofs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
finset.erase_nonefinset.erase_none
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option.to_finsetandfinset.insert_noneto a new filedata.finset.option; redefine the latter in terms offinset.cons;finset.erase_none, prove lemmas about it;finset.prod_cons,finset.sum_cons,finset.coe_cons,finset.cons_subset_cons,finset.card_cons;finset.subtype_monoandfinset.bUnion_congr;set.insert_subset_insert_iff;@[simp]tofinset.map_subset_map;finset.map_embeddingto anorder_embedding;@[simps]toequiv.option_is_some_equivandfunction.embedding.some;