[Merged by Bors] - feat(topology/connected.lean): add theorems about connectedness o… #9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f closure add two theorems is_preconnected.inclosure and is_connected.closure which formalize that if a set s is (pre)connected and a set t satisfies s ⊆ t ⊆ closure s, then t is (pre)connected as well modify is_preconnected.closure and is_connected.closure to take these theorems into account add a few comments for theorems in the code
PatrickMassot
added
the
awaiting-review
jcommelin
changed the title
jcommelin
reviewed
Oct 8, 2021
adamtopaz
reviewed
Oct 8, 2021
semorrison
added
awaiting-author
adamtopaz
reviewed
Oct 8, 2021
AntoineChambert-Loir
added
awaiting-review
|
It seems that All checks have passed. (What do the “8 skipped” mean?). |
adamtopaz
reviewed
Oct 11, 2021
adamtopaz
added
awaiting-author
|
8 skipped is nothing to worry about and can be ignored, it just means that some of the automated tests arent relevant for this type of PR. |
Following suggestions of Adam Topaz, the theorems is_preconnected.inclosure and is_connected.inclosure were renamed as is_preconnected.subset_closure and is_connected.subset_closure.
AntoineChambert-Loir
added
awaiting-review
ocfnash
reviewed
Oct 12, 2021
ocfnash
reviewed
Oct 12, 2021
ocfnash
reviewed
Oct 12, 2021
Co-authored-by: Oliver Nash <github@olivernash.org>
|
Nice work! bors d+ |
|
✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
…9633) feat(src/topology/connected.lean): add theorems about connectedness of closure add two theorems is_preconnected.inclosure and is_connected.closure which formalize that if a set s is (pre)connected and a set t satisfies s ⊆ t ⊆ closure s, then t is (pre)connected as well modify is_preconnected.closure and is_connected.closure to take these theorems into account add a few comments for theorems in the code Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr> Co-authored-by: Oliver Nash <github@olivernash.org>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(src/topology/connected.lean): add theorems about connectedness of closure
add two theorems is_preconnected.inclosure and is_connected.closure
which formalize that if a set s is (pre)connected
and a set t satisfies s ⊆ t ⊆ closure s,
then t is (pre)connected as well
modify is_preconnected.closure and is_connected.closure
to take these theorems into account
add a few comments for theorems in the code