[Merged by Bors] - refactor(data/complex/*): replace complex.conj and is_R_or_C.conj with star
#9640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Oct 18, 2021
eric-wieser
reviewed
Oct 18, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
… with star (#9640) This PR replaces `complex.conj` and `is_R_or_C.conj` by the star operation defined in `algebra/star`. Both of these are replaced with `star_ring_aut`, which is also made available under the notation `conj` defined in the locale `complex_conjugate`. This effectively also upgrades conj from a `ring_hom` to a `ring_aut`. Fixes #9421
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
… with star (#9640) This PR replaces `complex.conj` and `is_R_or_C.conj` by the star operation defined in `algebra/star`. Both of these are replaced with `star_ring_aut`, which is also made available under the notation `conj` defined in the locale `complex_conjugate`. This effectively also upgrades conj from a `ring_hom` to a `ring_aut`. Fixes #9421
|
Build failed: |
bryangingechen
added
awaiting-author
|
Looks like #9824 broke this. |
|
✌️ dupuisf can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
… with star (#9640) This PR replaces `complex.conj` and `is_R_or_C.conj` by the star operation defined in `algebra/star`. Both of these are replaced with `star_ring_aut`, which is also made available under the notation `conj` defined in the locale `complex_conjugate`. This effectively also upgrades conj from a `ring_hom` to a `ring_aut`. Fixes #9421
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
… with star (#9640) This PR replaces `complex.conj` and `is_R_or_C.conj` by the star operation defined in `algebra/star`. Both of these are replaced with `star_ring_aut`, which is also made available under the notation `conj` defined in the locale `complex_conjugate`. This effectively also upgrades conj from a `ring_hom` to a `ring_aut`. Fixes #9421
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
complex.conj and is_R_or_C.conj with starcomplex.conj and is_R_or_C.conj with star
eric-wieser
added
the
hacktoberfest-accepted
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
… with star (#9640) This PR replaces `complex.conj` and `is_R_or_C.conj` by the star operation defined in `algebra/star`. Both of these are replaced with `star_ring_aut`, which is also made available under the notation `conj` defined in the locale `complex_conjugate`. This effectively also upgrades conj from a `ring_hom` to a `ring_aut`. Fixes #9421
bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2022
…njugation) from `ring_equiv` to `ring_hom` and make type argument explicit (#11418) Change the underlying object notated by `conj` from ```lean def star_ring_aut [comm_semiring R] [star_ring R] : ring_aut R := ``` to ```lean def star_ring_end [comm_semiring R] [star_ring R] : R →+* R := ``` and also make the `R` argument explicit. These two changes allow the notation for conjugate-linear maps, `E →ₗ⋆[R] F` and variants, to pretty-print, see https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Pretty.20printer.20omits.20notation This is a partial reversion of #9640, in which complex conjugation was upgraded from `ring_hom` to `ring_equiv`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
complex.conjandis_R_or_C.conjby the star operation defined inalgebra/star. Both of these are replaced withstar_ring_aut, which is also made available under the notationconjdefined in the localecomplex_conjugate. This effectively also upgrades conj from aring_homto aring_aut.Fixes #9421