[Merged by Bors] - refactor(*): remove integral_domain, rename domain to is_domain #9748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
semorrison
commented
Oct 16, 2021
•
semorrison
commented
- depends on: [Merged by Bors] - refactor(*): replace comm_ring/integral_domain with ring/domain where possible #9739
- depends on: [Merged by Bors] - refactor(algebra/domain): make domain and integral_domain mixins #9719
- depends on: [Merged by Bors] - refactor(analysis/inner_product_space/projection): speedup proof #9804
…n_domain_old_structure_cmd
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
merge-conflict
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
removed
the
merge-conflict
semorrison
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.