Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/partition/finpartition): Finite partitions #9795

Closed
wants to merge 27 commits into from
Closed

[Merged by Bors] - feat(order/partition/finpartition): Finite partitions #9795

wants to merge 27 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 18, 2021 •
edited
Loading

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Oct 18, 2021
@bryangingechen
Copy link
Collaborator

This should be mentioned in data.setoid.partition and vice versa. Actually connecting the two notions might be out of the scope of this PR, but should be at least left for a TODO.

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 29, 2021
@JasonKYi JasonKYi mentioned this pull request Nov 4, 2021
Closed
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 4, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 11, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 12, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 13, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 15, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 15, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 3, 2022
@b-mehta
Copy link
Collaborator

b-mehta commented Jan 9, 2022

Small bump on this, do you need any help with filling in the gaps?

@YaelDillies
Copy link
Collaborator Author

Yes please! My plan is to build the infimum and supremum of finpartitions to demonstrate the benefit of not indexing them. It's not strictly necessary for the rest of Szemerédi but rather a matter of whether @eric-wieser is already convinced or not.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 9, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 28, 2022
@leanprover-community leanprover-community deleted a comment from github-actions bot Feb 7, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 7, 2022
jcommelin
jcommelin reviewed Feb 10, 2022
View reviewed changes
src/data/setoid/partition.lean Outdated Show resolved Hide resolved
src/order/partition/finpartition.lean Show resolved Hide resolved
@YaelDillies @jcommelin
typo
570ec03 
Co-authored-by: Johan Commelin <johan@commelin.net>
bryangingechen
bryangingechen approved these changes Feb 13, 2022
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I didn't try out the API myself yet. @eric-wieser any final comments?

jcommelin
jcommelin approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 14, 2022
bors bot pushed a commit that referenced this pull request Feb 14, 2022
@YaelDillies @b-mehta
feat(order/partition/finpartition): Finite partitions (#9795)
6550cba 
This defines finite partitions along with quite a few constructions,

Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com> 



Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
@bors
Copy link

bors bot commented Feb 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/partition/finpartition): Finite partitions [Merged by Bors] - feat(order/partition/finpartition): Finite partitions Feb 14, 2022
@bors bors bot closed this Feb 14, 2022
@bors bors bot deleted the finpartition branch February 14, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@b-mehta b-mehta b-mehta left review comments

@bryangingechen bryangingechen bryangingechen approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YaelDillies @bryangingechen @b-mehta @leanprover-community-bot-assistant @eric-wieser @jcommelin