Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed_space/is_R_or_C): add three lemmas on bounds of linear maps over is_R_or_C. #9827

Closed
wants to merge 3 commits into from

Conversation

kkytola
Copy link
Collaborator

@kkytola kkytola commented Oct 20, 2021

Adding lemmas linear_map.bound_of_sphere_bound, linear_map.bound_of_ball_bound, continuous_linear_map.op_norm_bound_of_ball_bound as a preparation of a PR on Banach-Alaoglu theorem.


I separated the three first lemmas of the proof https://github.com/kkytola/lean-questions/blob/main/alaoglu.lean of Banach-Alaoglu theorem, which I plan to PR next.

These three clearly need golfing and improving, but I hope the reviewers could help me with that. Doing them only in the generality of [is_R_or_C k] was discussed on Zulip https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there.20code.20for.20X.3F/topic/linear_map_bound_of_ball_bound/near/258265122.

I tend to believe the formulations are practical for real and complex linear maps, but in fact I don't know whether these are wanted in mathlib in the first place. Also I am not exactly sure where (in which file and which section) these should be placed, if at all. They require importing is_R_or_C, which in operator_norm.lean seemed to create a cyclic import.

Open in Gitpod

@sgouezel
Copy link
Collaborator

This looks good to me. I'd put them in a new file, however, to avoid importing complex stuff in bounded_linear_maps. Maybe create a new file normed_space.is_R_or_C where we could gather facts that are specific to R or C?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 23, 2021
@kkytola
Copy link
Collaborator Author

kkytola commented Oct 23, 2021

This looks good to me. I'd put them in a new file, however, to avoid importing complex stuff in bounded_linear_maps. Maybe create a new file normed_space.is_R_or_C where we could gather facts that are specific to R or C?

Sounds good, I did that. Thank you!

@kkytola kkytola changed the title feat(analysis/normed_space/operator_norm): add three lemmas on bounds of linear maps over is_R_or_C. feat(analysis/normed_space/is_R_or_C): add three lemmas on bounds of linear maps over is_R_or_C. Oct 23, 2021
@kkytola kkytola added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 23, 2021
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 24, 2021
bors bot pushed a commit that referenced this pull request Oct 24, 2021
…linear maps over is_R_or_C. (#9827)

Adding lemmas `linear_map.bound_of_sphere_bound`, `linear_map.bound_of_ball_bound`, `continuous_linear_map.op_norm_bound_of_ball_bound` as a preparation of a PR on Banach-Alaoglu theorem.
@bors
Copy link

bors bot commented Oct 24, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/is_R_or_C): add three lemmas on bounds of linear maps over is_R_or_C. [Merged by Bors] - feat(analysis/normed_space/is_R_or_C): add three lemmas on bounds of linear maps over is_R_or_C. Oct 24, 2021
@bors bors bot closed this Oct 24, 2021
@bors bors bot deleted the kkytola/linear_map_bound_of_ball_bound branch October 24, 2021 09:05
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
…linear maps over is_R_or_C. (#9827)

Adding lemmas `linear_map.bound_of_sphere_bound`, `linear_map.bound_of_ball_bound`, `continuous_linear_map.op_norm_bound_of_ball_bound` as a preparation of a PR on Banach-Alaoglu theorem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants