[Merged by Bors] - chore(data/fintype/basic): make units.fintype computable #9846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
1 task
jcommelin
approved these changes
Oct 21, 2021
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
jcommelin
added
awaiting-CI
github-actions
bot
added
the
delegated
jcommelin
reviewed
Oct 21, 2021
github-actions
bot
added
the
merge-conflict
…intype # Conflicts: # src/ring_theory/integral_domain.lean
github-actions
bot
removed
the
merge-conflict
|
@jcommelin: fixing CI resulted in some scope creep, would you mind taking a second look? |
github-actions
bot
removed
the
awaiting-CI
eric-wieser
added
the
awaiting-review
|
@eric-wieser Sure. (In such cases, I think it's best to remove |
jcommelin
reviewed
Oct 23, 2021
| @@ -115,10 +110,13 @@ begin | |||
| this, mul_one] | |||
| end | |||
|
|
|||
| section | |||
| variables [group_with_zero K] [fintype K] | |||
There was a problem hiding this comment.
This suggest that it really should move to a different file. Maybe in another PR?
|
bors merge |
github-actions
bot
added
ready-to-merge
jcommelin
added
the
awaiting-author
bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2021
This also: * renames `equiv.units_equiv_ne_zero` to `units_equiv_ne_zero`, and resolves the TODO comment about generalization * renames and generalizes `finite_field.card_units` to `fintype.card_units`, and proves it right next to the fintype instance * generalizes some typeclass assumptions in `finite_field.basic` as the linter already required me to tweak them
|
bors merge |
github-actions
bot
removed
the
awaiting-author
9 tasks
bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2021
This also: * renames `equiv.units_equiv_ne_zero` to `units_equiv_ne_zero`, and resolves the TODO comment about generalization * renames and generalizes `finite_field.card_units` to `fintype.card_units`, and proves it right next to the fintype instance * generalizes some typeclass assumptions in `finite_field.basic` as the linter already required me to tweak them
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
This also: * renames `equiv.units_equiv_ne_zero` to `units_equiv_ne_zero`, and resolves the TODO comment about generalization * renames and generalizes `finite_field.card_units` to `fintype.card_units`, and proves it right next to the fintype instance * generalizes some typeclass assumptions in `finite_field.basic` as the linter already required me to tweak them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also:
equiv.units_equiv_ne_zerotounits_equiv_ne_zero, and resolves the TODO comment about generalizationfinite_field.card_unitstofintype.card_units, and proves it right next to the fintype instancefinite_field.basicas the linter already required me to tweak them