Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(algebra/continued_fractions): remove use of open ... as #9847

Closed
wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

Lean 4 doesn't support the use of open ... as ..., so let's get rid of the few uses from mathlib rather than automating it in mathport.


Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 21, 2021
@semorrison
Copy link
Collaborator Author

Note there are no changes to the code here: just changes to open statements, removing many generalized_continued_fraction prefixes that aren't needed, and reflowing lines.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 23, 2021
@semorrison semorrison added the mathport For compatibility with Lean 4 changes, to simplify porting label Oct 23, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 23, 2021
bors bot pushed a commit that referenced this pull request Oct 23, 2021
Lean 4 doesn't support the use of `open ... as ...`, so let's get rid of the few uses from mathlib rather than automating it in mathport.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@sgouezel
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Oct 23, 2021
Lean 4 doesn't support the use of `open ... as ...`, so let's get rid of the few uses from mathlib rather than automating it in mathport.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/continued_fractions): remove use of open ... as [Merged by Bors] - refactor(algebra/continued_fractions): remove use of open ... as Oct 23, 2021
@bors bors bot closed this Oct 23, 2021
@bors bors bot deleted the remove_open_as branch October 23, 2021 17:10
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
Lean 4 doesn't support the use of `open ... as ...`, so let's get rid of the few uses from mathlib rather than automating it in mathport.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors mathport For compatibility with Lean 4 changes, to simplify porting ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants