[Merged by Bors] - refactor(linear_algebra/finite_dimensional): define finite_dimensional using module.finite #9854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c_finite_dimensional
riccardobrasca
added
awaiting-review
riccardobrasca
changed the title
github-actions
bot
added
merge-conflict
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
added
merge-conflict
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
the
delegated
|
✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
removed
the
awaiting-review
Co-authored-by: Johan Commelin <johan@commelin.net>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2021
…l using module.finite (#9854) `finite_dimensional K V` is by definition `is_noetherian K V`. We refactor this to use everywhere `finite K V` instead. To keep the PR reasonably small, we don't delete `finite_dimension`, but we define it as `module.finite`. In a future PR we will remove it. - [x] depends on: #9860
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
…l using module.finite (#9854) `finite_dimensional K V` is by definition `is_noetherian K V`. We refactor this to use everywhere `finite K V` instead. To keep the PR reasonably small, we don't delete `finite_dimension`, but we define it as `module.finite`. In a future PR we will remove it. - [x] depends on: #9860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finite_dimensional K Vis by definitionis_noetherian K V. We refactor this to use everywherefinite K Vinstead.To keep the PR reasonably small, we don't delete
finite_dimension, but we define it asmodule.finite. In a future PR we will remove it.