New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(topology/algebra/group_with_zero): continuity lemma for division #9959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
the
awaiting-review
The author would like community review of the PR
label
Oct 25, 2021
jcommelin
reviewed
Oct 26, 2021
urkud
reviewed
Oct 26, 2021
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
* This is a note with some tips how to formulate a continuity (or measurability, differentiability, ...) lemma. * I wanted to write this up after formulating `continuous.strans` in many "wrong" ways before discovering the "right" way. * I think many lemmas are not following this principle, and could be improved in generality and/or convenience by following this advice. * Based on experience from the sphere eversion project. * The note mentions a lemma that will be added in #9959, but I don't think we necessarily have to wait for that PR.
fpvandoorn
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 27, 2021
bors merge |
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Nov 4, 2021
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(topology/algebra/group_with_zero): continuity lemma for division
[Merged by Bors] - feat(topology/algebra/group_with_zero): continuity lemma for division
Nov 4, 2021
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
* This is a note with some tips how to formulate a continuity (or measurability, differentiability, ...) lemma. * I wanted to write this up after formulating `continuous.strans` in many "wrong" ways before discovering the "right" way. * I think many lemmas are not following this principle, and could be improved in generality and/or convenience by following this advice. * Based on experience from the sphere eversion project. * The note mentions a lemma that will be added in #9959, but I don't think we necessarily have to wait for that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
The PR author may merge after reviewing final suggestions.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0
.filter.tendsto_prod_top_iff
which is added by [Merged by Bors] - feat(topology/uniform_space): properties of uniform convergence #9958