Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*): update to Lean-3.35.0c #9988

Closed
wants to merge 17 commits into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 26, 2021

Move stream, rbtree, and rbmap from core to mathlib and reflows some long lines. Rename some files to avoid name clashes.


Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Oct 26, 2021
@urkud
Copy link
Member Author

urkud commented Oct 26, 2021

@gebner What are the two new types called stream in Lean 4?

@gebner
Copy link
Member

gebner commented Oct 26, 2021

Stream and Stream, obviously.

@urkud
Copy link
Member Author

urkud commented Oct 26, 2021

Stream and Stream, obviously.

These are typeclasses. We can have structure stream and an instance Stream (Stream α) α.

@urkud urkud changed the title chore(data/stream): move stream from core to mathlib chore(*): update to Lean-3.35.0c Oct 29, 2021
Released under Apache 2.0 license as described in the file LICENSE.
Authors: Leonardo de Moura
-/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief comment explaining why this is called init? I assume the reason is "it used to be part of the prelude"?

Released under Apache 2.0 license as described in the file LICENSE.
Authors: Leonardo de Moura
-/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly in this file, it would be nice to explain the choice of init in the filename.

@bors
Copy link

bors bot commented Oct 29, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I didn't check that the new files match the ones copied from core, I trust your copy pasting!

Can you add a comment to the PR description explaining the choice of init.lean filenames (and mention if these used to be part of the prelude but are no longer), and similarly add a comment to that end in each of the init.lean files?

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 29, 2021
@urkud
Copy link
Member Author

urkud commented Oct 30, 2021

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 30, 2021
bors bot pushed a commit that referenced this pull request Oct 30, 2021
Move `stream`, `rbtree`, and `rbmap` from core to `mathlib` and reflows some long lines. Rename some files to avoid name clashes.
@bors
Copy link

bors bot commented Oct 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): update to Lean-3.35.0c [Merged by Bors] - chore(*): update to Lean-3.35.0c Oct 30, 2021
@bors bors bot closed this Oct 30, 2021
@bors bors bot deleted the YK-stream-core branch October 30, 2021 03:52
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
Move `stream`, `rbtree`, and `rbmap` from core to `mathlib` and reflows some long lines. Rename some files to avoid name clashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants