[Merged by Bors] - feat(linear_algebra/matrix/adjugate): det_adjugate and adjugate_adjugate #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
eric-wieser
force-pushed
the
eric-wieser/det_adjugate
branch
from
e031b7f
to
5c3379f
Compare
eric-wieser
force-pushed
the
eric-wieser/det_adjugate
branch
from
efbb066
to
d0b802f
Compare
pechersky
reviewed
Oct 27, 2021
pechersky
reviewed
Oct 27, 2021
jcommelin
reviewed
Oct 27, 2021
| [comm_semiring R] [comm_semiring S] [algebra R S] (A : matrix m m S) : | ||
| (mv_polynomial.aeval $ λ p : m × m, A p.1 p.2).map_matrix (mv_polynomial_X m m R) = A := | ||
| mv_polynomial_X_map_eval₂ _ A | ||
|
|
There was a problem hiding this comment.
Could you please add some lemmas saying that the evaluation maps are surjective (and/or have partial inverses)?
There was a problem hiding this comment.
Can you be precise about what you consider to be the evaluation map, and in which argument you want to state surjectivity?
There was a problem hiding this comment.
Sorry, I was confused. mv_polynomial R ℤ has a surjective ring hom to R, by evaluation. I thought this was a variant on that, but it is of course slightly different.
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
eric-wieser
added
awaiting-review
jcommelin
approved these changes
Oct 28, 2021
| [comm_semiring R] [comm_semiring S] [algebra R S] (A : matrix m m S) : | ||
| (mv_polynomial.aeval $ λ p : m × m, A p.1 p.2).map_matrix (mv_polynomial_X m m R) = A := | ||
| mv_polynomial_X_map_eval₂ _ A | ||
|
|
There was a problem hiding this comment.
Sorry, I was confused. mv_polynomial R ℤ has a surjective ring hom to R, by evaluation. I thought this was a variant on that, but it is of course slightly different.
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
…ate (#9991) This also adds `matrix.mv_polynomial_X`
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
…ate (#9991) This also adds `matrix.mv_polynomial_X`
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
…ate (#9991) This also adds `matrix.mv_polynomial_X`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
…ate (#9991) This also adds `matrix.mv_polynomial_X`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds
matrix.mv_polynomial_X