This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[Merged by Bors] - feat(set_theory/surreal/dyadic): define add_monoid_hom structure on dyadic map #11052
Closed
Closed
[Merged by Bors] - feat(set_theory/surreal/dyadic): define add_monoid_hom structure on dyadic map #11052
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e44d7c5
Add pow_mk and log_mul.
apurvnakade 863549f
Upgrade dyadic_map to add_monoid_hom.
apurvnakade b4ddbf7
Review suggestions.
apurvnakade afd1d30
Update TODOs.
apurvnakade 05c4b1f
Review suggestions.
apurvnakade 1beaaa4
Add lift_on_zero lemma.
apurvnakade d4c22ee
Rewrite using lift_on_zero.
apurvnakade 635709e
Add dyadic_map_apply
apurvnakade c2ddc70
dyadic_map_apply_pow
apurvnakade d7aa25c
Add [simp].
apurvnakade 49604f9
Fix simp normal form.
apurvnakade File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have
simp
lemmas that proveh
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
bors d+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h
isn't always true though. The closest we have areint.pow_right_injective
andnat.pow_right_injective
.