Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/nat/factorization): Lemma on zero-ness of factorization #14560

Closed
wants to merge 3 commits into from

Conversation

Smaug123
Copy link
Collaborator

@Smaug123 Smaug123 commented Jun 5, 2022

Sad naming is sad.

Open in Gitpod

@Smaug123 Smaug123 added the awaiting-review The author would like community review of the PR label Jun 5, 2022
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
@Smaug123
Copy link
Collaborator Author

Smaug123 commented Jun 5, 2022

I'm not very well up on the naming conventions of mathlib, but factorization_apply_eq_zero_iff seems to me like the kind of thing I would only find indirectly by getting it wrong with a search for the string factorization_eq_zero, discovering the definition of factorization_eq_zero_iff, and then seeing that the lemma I wanted was the one immediately after it. If at all possible, I would prefer to keep factorization_eq_zero_iff as a substring, so that a text search will directly find the lemma.

@b-mehta
Copy link
Collaborator

b-mehta commented Jun 5, 2022

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 5, 2022
@bors
Copy link

bors bot commented Jun 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/factorization): Lemma on zero-ness of factorization [Merged by Bors] - feat(data/nat/factorization): Lemma on zero-ness of factorization Jun 5, 2022
@bors bors bot closed this Jun 5, 2022
@bors bors bot deleted the factorization-zero branch June 5, 2022 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants