This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 297
[Merged by Bors] - feat(ring_theory/valuation/valuation_subring): define maximal ideal of valuation subring and provide basic API #14656
Closed
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 001e35b - Browse repository at this point
Copy the full SHA 001e35bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed69042 - Browse repository at this point
Copy the full SHA ed69042View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4145d1b - Browse repository at this point
Copy the full SHA 4145d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ea8652 - Browse repository at this point
Copy the full SHA 6ea8652View commit details
Commits on Jun 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8b220a2 - Browse repository at this point
Copy the full SHA 8b220a2View commit details -
Merge branch 'valuation_maximal' of https://github.com/leanprover-com…
…munity/mathlib into valuation_maximal
Configuration menu - View commit details
-
Copy full SHA for 3eb2447 - Browse repository at this point
Copy the full SHA 3eb2447View commit details
Commits on Jun 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9687b52 - Browse repository at this point
Copy the full SHA 9687b52View commit details
Commits on Jun 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 222f853 - Browse repository at this point
Copy the full SHA 222f853View commit details
Commits on Jul 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5f5e971 - Browse repository at this point
Copy the full SHA 5f5e971View commit details
Commits on Jul 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8971c52 - Browse repository at this point
Copy the full SHA 8971c52View commit details -
Show
A.nonunits
agrees with the maximal ideal ofA
as an equality…… of subsets of `K`.
Configuration menu - View commit details
-
Copy full SHA for 52fcc37 - Browse repository at this point
Copy the full SHA 52fcc37View commit details -
Make argument to
mem_nonunits_iff
implicit because it's on both sid……es of the `iff`
Configuration menu - View commit details
-
Copy full SHA for 5b2c569 - Browse repository at this point
Copy the full SHA 5b2c569View commit details
Commits on Jul 15, 2022
-
Apply suggestions from code review
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87ecfba - Browse repository at this point
Copy the full SHA 87ecfbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0535212 - Browse repository at this point
Copy the full SHA 0535212View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4861ac6 - Browse repository at this point
Copy the full SHA 4861ac6View commit details
Commits on Jul 16, 2022
-
Update src/ring_theory/valuation/valuation_subring.lean
Co-authored-by: Johan Commelin <johan@commelin.net>
Configuration menu - View commit details
-
Copy full SHA for 167fda5 - Browse repository at this point
Copy the full SHA 167fda5View commit details
Commits on Jul 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f48a733 - Browse repository at this point
Copy the full SHA f48a733View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.