This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(analysis/special_functions/trigonometric/angle): topology #14969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give `real.angle` the structure of a `topological_add_group` (rather than just an `add_comm_group`), so that it's possible to talk about continuity for functions involving this type, and add associated continuity lemmas for `coe : ℝ → angle`, `real.angle.sin` and `real.angle.cos`.
|
The reported lint failure is so not a real lint failure; trying rerunning tests. |
ocfnash
reviewed
Jun 26, 2022
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
Give `real.angle` the structure of a `topological_add_group` (rather than just an `add_comm_group`), so that it's possible to talk about continuity for functions involving this type, and add associated continuity lemmas for `coe : ℝ → angle`, `real.angle.sin` and `real.angle.cos`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give
real.anglethe structure of atopological_add_group(ratherthan just an
add_comm_group), so that it's possible to talk aboutcontinuity for functions involving this type, and add associated
continuity lemmas for
coe : ℝ → angle,real.angle.sinandreal.angle.cos.