This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[Merged by Bors] - feat(data/pfun): Product of partial functions #15389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
The author would like community review of the PR
label
Jul 15, 2022
urkud
reviewed
Jul 17, 2022
urkud
reviewed
Jul 17, 2022
urkud
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Jul 17, 2022
YaelDillies
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Jul 17, 2022
prakol16
reviewed
Jul 28, 2022
prakol16
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Jul 28, 2022
YaelDillies
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Jul 30, 2022
b-mehta
reviewed
Aug 9, 2022
b-mehta
reviewed
Aug 12, 2022
@[simp] lemma dom_prod_lift (f : α →. β) (g : α →. γ) : | ||
(f.prod_lift g).dom = {x | (f x).dom ∧ (g x).dom} := rfl | ||
|
||
lemma get_prod_lift (f : α →. β) (g : α →. γ) (x : α) (h) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use simps
to generate these automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because α →. β × γ
is not a structure. Maybe something can be done, but I don't know how simps
works 😢
jcommelin
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-bot-assistant
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 20, 2022
bors bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
Define `pfun.prod : (α →. γ) → (β →. δ) → α × β →. γ × δ`.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(data/pfun): Product of partial functions
[Merged by Bors] - feat(data/pfun): Product of partial functions
Sep 20, 2022
b-mehta
pushed a commit
that referenced
this pull request
Sep 21, 2022
Define `pfun.prod : (α →. γ) → (β →. δ) → α × β →. γ × δ`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
pfun.prod : (α →. γ) → (β →. δ) → α × β →. γ × δ
.