Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/pfun): Product of partial functions #15389

Closed
wants to merge 8 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Define pfun.prod : (α →. γ) → (β →. δ) → α × β →. γ × δ.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jul 15, 2022
src/data/pfun.lean Outdated Show resolved Hide resolved
src/data/pfun.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 17, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 17, 2022
@jcommelin jcommelin requested a review from urkud July 17, 2022 22:35
src/data/pfun.lean Outdated Show resolved Hide resolved
@prakol16 prakol16 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 28, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 30, 2022
src/data/pfun.lean Outdated Show resolved Hide resolved
@[simp] lemma dom_prod_lift (f : α →. β) (g : α →. γ) :
(f.prod_lift g).dom = {x | (f x).dom ∧ (g x).dom} := rfl

lemma get_prod_lift (f : α →. β) (g : α →. γ) (x : α) (h) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use simps to generate these automatically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because α →. β × γ is not a structure. Maybe something can be done, but I don't know how simps works 😢

src/data/pfun.lean Outdated Show resolved Hide resolved
src/data/pfun.lean Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 20, 2022
bors bot pushed a commit that referenced this pull request Sep 20, 2022
Define `pfun.prod : (α →. γ) → (β →. δ) → α × β →. γ × δ`.
@bors
Copy link

bors bot commented Sep 20, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/pfun): Product of partial functions [Merged by Bors] - feat(data/pfun): Product of partial functions Sep 20, 2022
@bors bors bot closed this Sep 20, 2022
@bors bors bot deleted the pfun_prod branch September 20, 2022 13:01
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
Define `pfun.prod : (α →. γ) → (β →. δ) → α × β →. γ × δ`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants