This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(group_theory/free_group): norm of elements #15503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
reviewed
Jul 19, 2022
urkud
reviewed
Jul 19, 2022
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
urkud
reviewed
Jul 19, 2022
urkud
reviewed
Jul 19, 2022
kisonecat
added
the
awaiting-review
fpvandoorn
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
robertylewis
added
awaiting-author
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
|
Thank you @robertylewis and @urkud for your feedback on this. |
kisonecat
added
awaiting-review
urkud
reviewed
Jul 20, 2022
urkud
added
awaiting-author
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
kisonecat
added
awaiting-review
|
I'm going to cleanup the code locally, then push changes. |
|
I golfed some proofs but now we need a review from another maintainer. |
|
Thanks again to both of you. bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
This PR adds to a new `free_group.metric` namespace some useful lemmas related to the word metric on the free group. This will be useful for defining the word metric for an arbitrary (marked) group. Co-authored-by: Jim Fowler <fowler@math.osu.edu> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Oliver Nash <github@olivernash.org>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to a new
free_group.metricnamespace some useful lemmas related to the word metric on the free group. This will be useful for defining the word metric for an arbitrary (marked) group.