This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - lemmas about coeff for compute_degree
#15694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
adomani
added
awaiting-review
ocfnash
reviewed
Aug 1, 2022
ocfnash
added
awaiting-author
Co-authored-by: Oliver Nash <github@olivernash.org>
…mmunity/mathlib into adomani_coeff_lemmas
adomani
added
awaiting-review
|
Oliver, thank you very much for your comments: I implemented all of them! |
ocfnash
reviewed
Aug 1, 2022
Co-authored-by: Oliver Nash <github@olivernash.org>
ocfnash
approved these changes
Aug 1, 2022
|
|
||
| variables [ring R] {p q : R[X]} | ||
|
|
||
| lemma nat_degree_sub_le_iff_left (qn : q.nat_degree ≤ n) : |
There was a problem hiding this comment.
How about also adding the "right" version of this lemma:
lemma nat_degree_sub_le_iff_right (pn : p.nat_degree ≤ n) :
(p - q).nat_degree ≤ n ↔ q.nat_degree ≤ n :=There was a problem hiding this comment.
Done! I also added the "symmetric" lemma
lemma nat_degree_sub : (p - q).nat_degree = (q - p).nat_degree :=
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
This PR proves 5 lemmas about `coeff`s of polynomials under products, multiplications, sums and differences. I also moved an already existing `ring` lemma to a previously non-existing section on `ring`. These lemmas are useful for the `compute_degree` tactic of #15691.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
compute_degreecompute_degree
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
This PR proves 5 lemmas about `coeff`s of polynomials under products, multiplications, sums and differences. I also moved an already existing `ring` lemma to a previously non-existing section on `ring`. These lemmas are useful for the `compute_degree` tactic of #15691.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proves 5 lemmas about
coeffs of polynomials under products, multiplications, sums and differences.I also moved an already existing
ringlemma to a previously non-existing section onring.These lemmas are useful for the
compute_degreetactic of #15691.