Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(order/extension/well): Extend a well-founded order #17054

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(order/extension/well): Extend a well-founded order #17054

wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 18, 2022 •
edited
Loading

A well-founded order can be extended to a well order.

For this, we need the rank of an an element of a well-founded order.

Also rename order.extension to order.extension.linear.

Co-authored-by: Junyan Xu junyanxumath@gmail.com

From Con(NF)

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Oct 18, 2022
Vierkantor
Vierkantor reviewed Oct 27, 2022
View reviewed changes
src/order/extension/well.lean Outdated Show resolved Hide resolved
src/set_theory/ordinal/arithmetic.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 27, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 28, 2022
alreadydone
alreadydone reviewed Oct 28, 2022
View reviewed changes
src/set_theory/ordinal/arithmetic.lean Show resolved Hide resolved
src/set_theory/ordinal/arithmetic.lean Show resolved Hide resolved
src/order/extension/well.lean Outdated Show resolved Hide resolved
src/set_theory/ordinal/arithmetic.lean Outdated Show resolved Hide resolved
src/set_theory/ordinal/arithmetic.lean Outdated Show resolved Hide resolved
src/order/extension/well.lean Outdated Show resolved Hide resolved
src/order/extension/well.lean Outdated Show resolved Hide resolved
@alreadydone alreadydone added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 29, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 29, 2022
@alreadydone alreadydone added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 30, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 30, 2022
alreadydone
alreadydone approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All look good to me, but since I wrote a large part of the PR it's better that someone else calls merge.

Vierkantor
Vierkantor approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/order/extension/well.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 31, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 31, 2022
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 31, 2022
@YaelDillies @alreadydone
feat(order/extension/well): Extend a well-founded order (#17054)
65ee857 
A well-founded order can be extended to a well order.

For this, we need the rank of an an element of a well-founded order.

Also rename `order.extension` to `order.extension.linear`.

Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@bors
Copy link

bors bot commented Oct 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/extension/well): Extend a well-founded order [Merged by Bors] - feat(order/extension/well): Extend a well-founded order Oct 31, 2022
@bors bors bot closed this Oct 31, 2022
@bors bors bot deleted the exists_well_order_ge branch October 31, 2022 20:01
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alreadydone alreadydone alreadydone approved these changes

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YaelDillies @Vierkantor @alreadydone @eric-wieser @leanprover-community-bot-assistant