This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Merged by Bors] - refactor(data/polynomial): Move some lemmas to
monoid_algebra
#4627[Merged by Bors] - refactor(data/polynomial): Move some lemmas to
monoid_algebra
#4627Changes from 3 commits
2dec134
d577a63
75646cd
b112b92
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this proof is actually longer in
add_monoid_algebra
:https://github.com/leanprover-community/mathlib/blob/7559d1c8797485c95bab68d0f1d897a17ce60b2e/src/algebra/monoid_algebra.lean#L598-L612
Should I change the proof there to use this shorter proof, or is the long one more readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mul_single_apply_aux
is used more than 1 time inmonoid_algebra
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.