This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(ring_theory/ideal/operations): add an instance #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
added
the
awaiting-review
Closed
1 task
eric-wieser
reviewed
Mar 16, 2021
| @@ -1235,6 +1235,12 @@ by simp only [ring_hom.algebra_map_to_algebra, ring_hom.comp_id] | |||
| instance {I : ideal A} : is_scalar_tower R A (ideal.quotient I) := | |||
| is_scalar_tower.of_algebra_map_eq' (quotient.alg_map_eq R I) | |||
|
|
|||
| instance quotient.is_scalar_tower' [algebra S A] [algebra S R] [is_scalar_tower S R A] | |||
There was a problem hiding this comment.
I think this one subsumes the instance above, so the one above can be removed. I doubt that will fix the timeout though.
Thanks for making the PR
There was a problem hiding this comment.
Indeed it doesn't...
If we want to keep this just for the record, should I close the PR?
There was a problem hiding this comment.
I'll have a play with this tomorrow, now that you have a cache ready for me!
eric-wieser
added
not-ready-to-merge
WIP
bryangingechen
changed the title
|
@eric-wieser should I close this or do you want to work on it? |
eric-wieser
reviewed
Mar 22, 2021
|
Well, I got CI passing on this (the failure was just a long line); I just haven't decided if it's actually a good idea. |
eric-wieser
reviewed
Mar 22, 2021
|
I can very well be wrong, but it seems to me a good instance to have. |
riccardobrasca
added
awaiting-review
|
Oh nice, I hadn't realized that this enabled more golfing. |
Vierkantor
approved these changes
Mar 26, 2021
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2021
This instance has been suggested by @eric-wieser in #6640. On my machine I get a deterministic timeout in `ring_theory/finiteness` at line 325, but in principle it seems a useful instance to have. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
This instance has been suggested by @eric-wieser in #6640. On my machine I get a deterministic timeout in `ring_theory/finiteness` at line 325, but in principle it seems a useful instance to have. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instance has been suggested by @eric-wieser in #6640.
On my machine I get a deterministic timeout in
ring_theory/finitenessat line 325, but in principle it seems a useful instance to have.