This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(topology/instances/real): remove instance real_maps_algebra
#6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
the
awaiting-review
eric-wieser
reviewed
Mar 28, 2021
| @@ -285,11 +284,6 @@ eq_Icc_of_connected_compact ⟨(nonempty_Icc.2 hab).image f, is_preconnected_Icc | |||
|
|
|||
| end | |||
|
|
|||
| instance reals_semimodule : has_continuous_smul ℝ ℝ := ⟨continuous_mul⟩ | |||
There was a problem hiding this comment.
To confirm, this instance already exists as has_contnuous_mul.has_continuous_smul [sic, #6921]
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2021
…6920) Remove ```lean instance reals_semimodule : has_continuous_smul ℝ ℝ instance real_maps_algebra {α : Type*} [topological_space α] : algebra ℝ C(α, ℝ) ``` These are not used explicitly anywhere in the library, I suspect because if needed they can be found by typeclass inference. Deleting them cleans up the import hierarchy by requiring many fewer files to import `topology.continuous_function.algebra`.
|
Build failed (retrying...): |
|
bors r- Sorry, this seems to be one of my recent PRs conflicting with another. |
|
Canceled. |
|
I fixed the build, should be fine to merge. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
…6920) Remove ```lean instance reals_semimodule : has_continuous_smul ℝ ℝ instance real_maps_algebra {α : Type*} [topological_space α] : algebra ℝ C(α, ℝ) ``` These are not used explicitly anywhere in the library, I suspect because if needed they can be found by typeclass inference. Deleting them cleans up the import hierarchy by requiring many fewer files to import `topology.continuous_function.algebra`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
real_maps_algebrareal_maps_algebra
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…6920) Remove ```lean instance reals_semimodule : has_continuous_smul ℝ ℝ instance real_maps_algebra {α : Type*} [topological_space α] : algebra ℝ C(α, ℝ) ``` These are not used explicitly anywhere in the library, I suspect because if needed they can be found by typeclass inference. Deleting them cleans up the import hierarchy by requiring many fewer files to import `topology.continuous_function.algebra`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
These are not used explicitly anywhere in the library, I suspect because if needed they can be found by typeclass inference. Deleting them cleans up the import hierarchy by requiring many fewer files to import
topology.continuous_function.algebra.