-
Notifications
You must be signed in to change notification settings - Fork 299
[Merged by Bors] - chore(src/linear_algebra/free_module): rename file to free_module_pid #7805
Conversation
Can you update the docstring in the moved file to explain what pid stands for? |
Let me know if this is not clear enough :) |
Looks ok to me, possibly worth referencing the lean spelling of PID if there is one. I'll leave this to @Vierkantor who wrote the original docstring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, the contents of the file diverged quite a bit from how I originally envisioned them when I named it. How does this docstring sound?
bors d+
✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
bors r+ |
Pull request successfully merged into master. Build succeeded: |
In preparation for #7801