This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
feat(*): has_mem (set α) (filter α) #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @johoelzl for merging this quickly! |
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the long overdue instance
has_mem (set α) (filter α). It gets rid of countless.setsand parentheses, and make every filter use closer to the real world thing. There are still a couple of inconveniences: of course we still have a couple of lemmas about the sets of a filter, and rewriting using them is not always possible, even though the instance is reducible. The workaround is to add a couple ofshoworchange, or type ascriptions when using the funny triangle. I also addedmem_infito replace many uses ofinfi_sets_eq.A weirder thing is in
asymptotics.leanwhereusetimes out. I replaced those bbyrefineand everything works smoothly.