Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): has_mem (set α) (filter α) #799

Merged
merged 1 commit into from Mar 8, 2019
Merged

feat(*): has_mem (set α) (filter α) #799

merged 1 commit into from Mar 8, 2019

Conversation

PatrickMassot
Copy link
Member

This is the long overdue instance has_mem (set α) (filter α). It gets rid of countless .sets and parentheses, and make every filter use closer to the real world thing. There are still a couple of inconveniences: of course we still have a couple of lemmas about the sets of a filter, and rewriting using them is not always possible, even though the instance is reducible. The workaround is to add a couple of show or change, or type ascriptions when using the funny triangle. I also added mem_infi to replace many uses of infi_sets_eq.

A weirder thing is in asymptotics.lean where use times out. I replaced those bby refine and everything works smoothly.

Copy link
Collaborator

@johoelzl johoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@johoelzl johoelzl merged commit ffa6d69 into master Mar 8, 2019
@johoelzl johoelzl deleted the has_mem_filter branch March 8, 2019 07:47
@PatrickMassot
Copy link
Member Author

Thanks @johoelzl for merging this quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants