Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(group_theory/coset): card_dvd_of_injective #8485

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(group_theory/coset): card_dvd_of_injective #8485

wants to merge 3 commits into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Aug 1, 2021
PatrickMassot
PatrickMassot reviewed Aug 1, 2021
View reviewed changes
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/group_theory/coset.lean Outdated

lemma card_dvd_of_injective [fintype α] [fintype H] (f : α →* H) (hf : function.injective f) :
card α ∣ card H :=
by classical; exact
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exact isn't needed, right? And the indentation seems weird. Same remark in the next proof.

@bors
Copy link

bors bot commented Aug 1, 2021

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 1, 2021
@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Aug 1, 2021
@ChrisHughes24
Copy link
Member Author

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 2, 2021
bors bot pushed a commit that referenced this pull request Aug 2, 2021
@ChrisHughes24
feat(group_theory/coset): card_dvd_of_injective (#8485)
1b771af
@bors
Copy link

bors bot commented Aug 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/coset): card_dvd_of_injective [Merged by Bors] - feat(group_theory/coset): card_dvd_of_injective Aug 2, 2021
@bors bors bot closed this Aug 2, 2021
@bors bors bot deleted the card_dvd_of_injective branch August 2, 2021 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisHughes24 @PatrickMassot