This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(linear_algebra/matrix/nonsingular_inverse): adjugate_mul_distrib #8682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provide the same lemmas for multiset.
This golfs/generalizes some proofs. Additionally, provide some helper API for `is_regular`, for non-zeros in domains, and for smul of units.
…lynomials Additionally, provide results for degree and nat_degree over lists, which generalize away from requiring commutativity.
…_aux We prove towards the fact that the adjugate of a matrix distributes over the product. The current proof assumes regularity of the matrices. In the general case, this hypothesis is not required, but this lemma will be crucial in a follow-up PR which has to use polynomial matrices for the general case. Additionally, we provide many API lemmas for det, cramer, nonsing_inv, and adjugate.
We prove that the adjugate of a matrix distributes over the product. To do so, a separate file `linear_algebra.matrix.polynomial` states some general facts about the polynomial `det (t I + A)`.
github-actions
bot
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Aug 15, 2021
pechersky
added
awaiting-author
A reviewer has asked the author a question or requested changes
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
labels
Aug 15, 2021
2 tasks
Also provide same lemma for finsupp, and specialize it for matrices
github-actions
bot
added
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Aug 18, 2021
github-actions
bot
added
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Aug 25, 2021
github-actions
bot
added
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
and removed
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
labels
Aug 25, 2021
github-actions
bot
removed
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Aug 27, 2021
github-actions
bot
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Aug 27, 2021
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
pechersky
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Aug 27, 2021
Vierkantor
reviewed
Sep 1, 2021
pechersky
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 1, 2021
pechersky
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Sep 1, 2021
Vierkantor
reviewed
Sep 2, 2021
Vierkantor
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That adjugate_mul_distrib
is a slick proof 😍
bors d+
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 6, 2021
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
…#8682) We prove that the adjugate of a matrix distributes over the product. To do so, a separate file `linear_algebra.matrix.polynomial` states some general facts about the polynomial `det (t I + A)`. Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(linear_algebra/matrix/nonsingular_inverse): adjugate_mul_distrib
[Merged by Bors] - feat(linear_algebra/matrix/nonsingular_inverse): adjugate_mul_distrib
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prove that the adjugate of a matrix distributes over the product. To do so, a separate file
linear_algebra.matrix.polynomial
states some general facts about the polynomialdet (t I + A)
.Should the polynomial file be somehow merged with the
char_poly
file?