Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(order/prime_ideal): prime ideals are maximal #9004

Closed
wants to merge 18 commits into from

Conversation

atarnoam
Copy link
Collaborator

@atarnoam atarnoam commented Sep 4, 2021

Proved that in boolean algebras:

  1. An ideal is prime iff it always contains one of x, x^c
  2. A prime ideal is maximal

Open in Gitpod

atarnoam and others added 11 commits September 3, 2021 17:55
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
- Added is_proper.not_mem_of_compl_mem
- Added is_proper.not_mem_or_compl_not_mem
- Changed signature of is_prime_of_mem_or_compl_mem
@bryangingechen bryangingechen added the awaiting-review The author would like community review of the PR label Sep 5, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Please structure your subproofs into blocks as explained in the style guide.

src/order/ideal.lean Outdated Show resolved Hide resolved
src/order/ideal.lean Outdated Show resolved Hide resolved
src/order/prime_ideal.lean Outdated Show resolved Hide resolved
src/order/prime_ideal.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 6, 2021
atarnoam and others added 2 commits September 6, 2021 16:23
Co-authored-by: Johan Commelin <johan@commelin.net>
@atarnoam atarnoam added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 6, 2021
@bors
Copy link

bors bot commented Sep 6, 2021

✌️ atarnoam can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested two more golfs. Thanks 🎉

bors d+

src/order/prime_ideal.lean Outdated Show resolved Hide resolved
src/order/prime_ideal.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 6, 2021
atarnoam and others added 2 commits September 6, 2021 16:58
Co-authored-by: Johan Commelin <johan@commelin.net>
@atarnoam
Copy link
Collaborator Author

atarnoam commented Sep 6, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 6, 2021
Proved that in boolean algebras:
1. An ideal is prime iff it always contains one of x, x^c
2. A prime ideal is maximal
@bors
Copy link

bors bot commented Sep 6, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 6, 2021
Proved that in boolean algebras:
1. An ideal is prime iff it always contains one of x, x^c
2. A prime ideal is maximal
@bors
Copy link

bors bot commented Sep 6, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 7, 2021
Proved that in boolean algebras:
1. An ideal is prime iff it always contains one of x, x^c
2. A prime ideal is maximal
@bors
Copy link

bors bot commented Sep 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/prime_ideal): prime ideals are maximal [Merged by Bors] - feat(order/prime_ideal): prime ideals are maximal Sep 7, 2021
@bors bors bot closed this Sep 7, 2021
@bors bors bot deleted the primes-in-boolean-algebras branch September 7, 2021 01:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants