This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/real/ennreal): add ennreal.to_(nn)real_inv and ennreal.to_(nn)real_div #9144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RemyDegenne
commented
Sep 11, 2021
RemyDegenne
commented
RemyDegenne
added
the
awaiting-review
Closed
1 task
eric-wieser
reviewed
Sep 11, 2021
| @@ -1489,6 +1505,12 @@ lemma to_real_prod {ι : Type*} {s : finset ι} {f : ι → ℝ≥0∞} : | |||
| (∏ i in s, f i).to_real = ∏ i in s, (f i).to_real := | |||
| to_real_hom.map_prod _ _ | |||
|
|
|||
| lemma to_real_inv (a : ℝ≥0∞) : (a⁻¹).to_real = (a.to_real)⁻¹ := | |||
| by { simp_rw ennreal.to_real, norm_cast, exact to_nnreal_inv a, } | |||
There was a problem hiding this comment.
Can you prove this with monoid_with_zero_hom.map_inv'? I'm pretty sure to_real_hom can be promoted to that stronger type.
There was a problem hiding this comment.
ennreal doesn't have the required instance: failed to synthesize type class instance for group_with_zero ℝ≥0∞
There was a problem hiding this comment.
I mean that I can indeed promote to_nnreal_hom to a monoid_with_zero_hom, but I cannot use map_inv'
|
bors r+ |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.