Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/nat/log): add antitonicity lemmas for first argument #9597

Closed
wants to merge 4 commits into from

Conversation

jchoules
Copy link
Collaborator

@jchoules jchoules commented Oct 7, 2021

log and clog are only antitone on bases >1, so we include this as an
assumption in log_le_log_of_left_ge (resp. clog_le_...) and as a
domain restriction in log_left_gt_one_anti (resp. clog_left_...).


Open in Gitpod

`log` and `clog` are only antitone on bases >1, so we include this as an
assumption in `log_le_log_of_left_ge` (resp. `clog_le_...`) and as a
domain restriction in `log_left_gt_one_anti` (resp. `clog_left_...`).
@jchoules jchoules added the awaiting-review The author would like community review of the PR label Oct 7, 2021
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I commented the log part and trust your generalization skills to take care of the clog one.

src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 8, 2021
bors bot pushed a commit that referenced this pull request Oct 8, 2021
`log` and `clog` are only antitone on bases >1, so we include this as an
assumption in `log_le_log_of_left_ge` (resp. `clog_le_...`) and as a
domain restriction in `log_left_gt_one_anti` (resp. `clog_left_...`).
@bors
Copy link

bors bot commented Oct 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/log): add antitonicity lemmas for first argument [Merged by Bors] - feat(data/nat/log): add antitonicity lemmas for first argument Oct 8, 2021
@bors bors bot closed this Oct 8, 2021
@bors bors bot deleted the log_left_anti branch October 8, 2021 10:04
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants