This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(data/nat/log): add antitonicity lemmas for first argument #9597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`log` and `clog` are only antitone on bases >1, so we include this as an assumption in `log_le_log_of_left_ge` (resp. `clog_le_...`) and as a domain restriction in `log_left_gt_one_anti` (resp. `clog_left_...`).
jchoules
added
the
awaiting-review
The author would like community review of the PR
label
Oct 7, 2021
YaelDillies
reviewed
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I commented the log
part and trust your generalization skills to take care of the clog
one.
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 8, 2021
bors bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
`log` and `clog` are only antitone on bases >1, so we include this as an assumption in `log_le_log_of_left_ge` (resp. `clog_le_...`) and as a domain restriction in `log_left_gt_one_anti` (resp. `clog_left_...`).
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(data/nat/log): add antitonicity lemmas for first argument
[Merged by Bors] - feat(data/nat/log): add antitonicity lemmas for first argument
Oct 8, 2021
eric-wieser
added
the
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
label
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log
andclog
are only antitone on bases >1, so we include this as anassumption in
log_le_log_of_left_ge
(resp.clog_le_...
) and as adomain restriction in
log_left_gt_one_anti
(resp.clog_left_...
).