This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(measure_theory/covering/vitali): Vitali covering theorems #9680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
added
the
awaiting-review
The author would like community review of the PR
label
Oct 12, 2021
urkud
reviewed
Oct 13, 2021
urkud
reviewed
Oct 13, 2021
Comment on lines
163
to
165
by_cases t_eq_empty : t = {∅}, | ||
{ rw t_eq_empty, | ||
refine ⟨{∅}, subset.refl _, _⟩, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
by_cases t_eq_empty : t = {∅}, | |
{ rw t_eq_empty, | |
refine ⟨{∅}, subset.refl _, _⟩, | |
rcases eq_or_ne t {∅} with (rfl|t_ne_empty), | |
{ refine ⟨{∅}, subset.refl _, _⟩, |
Also, you can rule out t.subsingleton
instead of t = ∅
in the first rcases
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but it did not turn out really shorter or clearer, so in the end I came back to my original version. If you see a way which is shorter and clearer, don't hesitate to push directly to the branch!
jcommelin
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 13, 2021
sgouezel
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Oct 13, 2021
Thanks! |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 15, 2021
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
The topological and measurable Vitali covering theorems. * topological version: if a space is covered by balls `(B (x_i, r_i))_{i \in I}`, one can extract a disjointed subfamily indexed by `J` such that the space is covered by the balls `B (x_j, 5 r_j)`. * measurable version: if additionally the measure has a doubling-like property, and the covering contains balls of arbitrarily small radius at every point, then the disjointed subfamily one obtains above covers almost all the space. These two statements are particular cases of more general statements that are proved in this PR.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(measure_theory/covering/vitali): Vitali covering theorems
[Merged by Bors] - feat(measure_theory/covering/vitali): Vitali covering theorems
Oct 16, 2021
eric-wieser
added
the
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
label
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topological and measurable Vitali covering theorems.
(B (x_i, r_i))_{i \in I}
, one can extract a disjointed subfamily indexed byJ
such that the space is covered by the ballsB (x_j, 5 r_j)
.These two statements are particular cases of more general statements that are proved in this PR.