Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl #9955

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl #9955

wants to merge 2 commits into from

Conversation

pechersky
Copy link
Collaborator

Provide definitional lemmas about sdiff and compl on pi types.
This allows usage later on even without a whole boolean_algebra instance.

Open in Gitpod

@pechersky
refactor(order/boolean_algebra): factor out sdiff and compl
7027c06 
Provide definitional lemmas about sdiff and compl on pi types.
This allows usage later on even without a whole `boolean_algebra` instance.
@pechersky pechersky changed the title refactor(order/boolean_algebra): factor out sdiff and compl refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl Oct 25, 2021
@pechersky pechersky added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Oct 25, 2021
@pechersky pechersky mentioned this pull request Oct 25, 2021
Closed
@bors
Copy link

bors bot commented Oct 25, 2021

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

eric-wieser
eric-wieser approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add pi.sdiff_def and pi.compl_def to match pi.add_def etc too?

bors d+

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 25, 2021
@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2021
@pechersky
refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl (#9955
b592589 
)

Provide definitional lemmas about sdiff and compl on pi types.
This allows usage later on even without a whole `boolean_algebra` instance.
@bors
Copy link

bors bot commented Oct 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl [Merged by Bors] - refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl Oct 27, 2021
@bors bors bot closed this Oct 27, 2021
@bors bors bot deleted the pechersky/pi-boolean-algebra branch October 27, 2021 01:07
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
@pechersky @ericrbg
refactor(order/boolean_algebra): factor out pi.sdiff and pi.compl (#9955
5fe9dfb 
)

Provide definitional lemmas about sdiff and compl on pi types.
This allows usage later on even without a whole `boolean_algebra` instance.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@urkud urkud Awaiting requested review from urkud

@fpvandoorn fpvandoorn Awaiting requested review from fpvandoorn

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pechersky @eric-wieser