Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(order/iterate): review, add docs #9965

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(order/iterate): review, add docs #9965

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 25, 2021

  • reorder sections;
  • add section docs;
  • use inequalities between functions in a few statements;
  • add a few lemmas about strict_mono functions.

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Oct 25, 2021
jcommelin
jcommelin approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 26, 2021
bors bot pushed a commit that referenced this pull request Oct 26, 2021
@urkud
chore(order/iterate): review, add docs (#9965)
367d71e 
* reorder sections;
* add section docs;
* use inequalities between functions in a few statements;
* add a few lemmas about `strict_mono` functions.
@bors
Copy link

bors bot commented Oct 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/iterate): review, add docs [Merged by Bors] - chore(order/iterate): review, add docs Oct 26, 2021
@bors bors bot closed this Oct 26, 2021
@bors bors bot deleted the YK-order-iterate branch October 26, 2021 09:09
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
YaelDillies
YaelDillies reviewed Oct 27, 2021
View reviewed changes
src/order/iterate.lean
∀ n, (f^[n]) ≤ id :=
@id_le_iterate_of_id_le (order_dual α) _ f h

lemma iterate_le_iterate_of_id_le (h : id ≤ f) {m n : ℕ} (hmn : m ≤ n) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete this lemma? I'm using it on a branch.

EDIT: I'm dumb.

ericrbg pushed a commit that referenced this pull request Nov 9, 2021
@urkud @ericrbg
chore(order/iterate): review, add docs (#9965)
a5a0e6a 
* reorder sections;
* add section docs;
* use inequalities between functions in a few statements;
* add a few lemmas about `strict_mono` functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @jcommelin @YaelDillies @eric-wieser