Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups to #3838 #6268

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Fixups to #3838 #6268

wants to merge 20 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jul 31, 2023

@eric-wieser eric-wieser added the WIP Work in progress label Jul 31, 2023
@semorrison
Copy link
Contributor

I would prefer to revert the universe polymorphism from #5796 rather than leave this in limbo. Certainly not urgent, but I don't want to just forget about this problem.

@semorrison
Copy link
Contributor

Could something be done about this? I would be sad if this unnecessary universe polymorphism change permanently prevents us from using MetaM in slim_check.

I would like to either see this PR made to work, or the universe polymorphism change reverted.

@eric-wieser eric-wieser changed the base branch from slim_check_metam to master December 1, 2023 14:23
Mathlib/Testing/SlimCheck/Gen.lean Outdated Show resolved Hide resolved
Mathlib/Testing/SlimCheck/Testable.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 2, 2023
Mathlib/Testing/SlimCheck/Sampleable.lean Outdated Show resolved Hide resolved
Mathlib/Testing/SlimCheck/Sampleable.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 12, 2023
Mathlib/Testing/SlimCheck/Sampleable.lean Outdated Show resolved Hide resolved
Mathlib/Testing/SlimCheck/Sampleable.lean Outdated Show resolved Hide resolved
Mathlib/Testing/SlimCheck/Testable.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 17, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants