Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting note: added dsimp only #10752

Open
pitmonticone opened this issue Feb 20, 2024 · 1 comment
Open

Porting note: added dsimp only #10752

pitmonticone opened this issue Feb 20, 2024 · 1 comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.

Comments

@pitmonticone
Copy link
Collaborator

pitmonticone commented Feb 20, 2024

Classifies porting notes claiming added dsimp only.

Examples

-- To match `AdjoinRoot.lift`
/-- Lift a ring homomorphism `R →+* T` to `S →+* T` by specifying a root `x` of `f` in `T`,
where `S` is given by adjoining a root of `f` to `R`. -/
def lift (h : IsAdjoinRoot S f) : S →+* T where
toFun z := (h.repr z).eval₂ i x
map_zero' := by
dsimp only -- Porting note: added
rw [h.eval₂_repr_eq_eval₂_of_map_eq hx _ _ (map_zero _), eval₂_zero]
map_add' z w := by
dsimp only -- Porting note: added
rw [h.eval₂_repr_eq_eval₂_of_map_eq hx _ (h.repr z + h.repr w), eval₂_add]
· rw [map_add, map_repr, map_repr]
map_one' := by
dsimp only -- Porting note: added
rw [h.eval₂_repr_eq_eval₂_of_map_eq hx _ _ (map_one _), eval₂_one]
map_mul' z w := by
dsimp only -- Porting note: added
rw [h.eval₂_repr_eq_eval₂_of_map_eq hx _ (h.repr z * h.repr w), eval₂_mul]
· rw [map_mul, map_repr, map_repr]
#align is_adjoin_root.lift IsAdjoinRoot.lift

@pitmonticone pitmonticone added the porting-notes Mathlib3 to Mathlib4 porting notes. label Feb 20, 2024
mathlib-bors bot pushed a commit that referenced this issue Feb 20, 2024
Classifies by adding issue number (#10752) to porting notes claiming `added dsimp only`.
thorimur pushed a commit that referenced this issue Feb 24, 2024
Classifies by adding issue number (#10752) to porting notes claiming `added dsimp only`.
thorimur pushed a commit that referenced this issue Feb 26, 2024
Classifies by adding issue number (#10752) to porting notes claiming `added dsimp only`.
riccardobrasca pushed a commit that referenced this issue Mar 1, 2024
Classifies by adding issue number (#10752) to porting notes claiming `added dsimp only`.
dagurtomas pushed a commit that referenced this issue Mar 22, 2024
Classifies by adding issue number (#10752) to porting notes claiming `added dsimp only`.
@grunweg
Copy link
Collaborator

grunweg commented Apr 14, 2024

Some of these turn out to be #12129; I'm re-classifying these in #12130.

mathlib-bors bot pushed a commit that referenced this issue Apr 15, 2024
…ion (#12130)

This subsumes some of the notes in #10752 and #10971.
I'm on the fence as to whether replacing the dsimp only by beta_reduce is useful; this is easy to revert if needed.
Louddy pushed a commit that referenced this issue Apr 15, 2024
…ion (#12130)

This subsumes some of the notes in #10752 and #10971.
I'm on the fence as to whether replacing the dsimp only by beta_reduce is useful; this is easy to revert if needed.
atarnoam pushed a commit that referenced this issue Apr 16, 2024
…ion (#12130)

This subsumes some of the notes in #10752 and #10971.
I'm on the fence as to whether replacing the dsimp only by beta_reduce is useful; this is easy to revert if needed.
uniwuni pushed a commit that referenced this issue Apr 19, 2024
…ion (#12130)

This subsumes some of the notes in #10752 and #10971.
I'm on the fence as to whether replacing the dsimp only by beta_reduce is useful; this is easy to revert if needed.
callesonne pushed a commit that referenced this issue Apr 22, 2024
…ion (#12130)

This subsumes some of the notes in #10752 and #10971.
I'm on the fence as to whether replacing the dsimp only by beta_reduce is useful; this is easy to revert if needed.
Jun2M pushed a commit that referenced this issue Apr 24, 2024
…ion (#12130)

This subsumes some of the notes in #10752 and #10971.
I'm on the fence as to whether replacing the dsimp only by beta_reduce is useful; this is easy to revert if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.
Projects
None yet
Development

No branches or pull requests

2 participants