Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_additive should translate the names of recursor arguments in elab_as_elim #11462

Open
eric-wieser opened this issue Mar 17, 2024 · 0 comments
Open

to_additive should translate the names of recursor arguments in elab_as_elim #11462

eric-wieser opened this issue Mar 17, 2024 · 0 comments
Labels
t-algebra Algebra (groups, rings, fields etc) t-meta Tactics, attributes or user commands

Comments

@eric-wieser
Copy link
Member

Without this we get nonsense like

induction ha using AddSubmonoid.closure_induction' with
| mem => _
| one => _
| mul => _

instead of

induction ha using AddSubmonoid.closure_induction' with
| mem => _
| zero => _
| add => _
@eric-wieser eric-wieser added t-meta Tactics, attributes or user commands t-algebra Algebra (groups, rings, fields etc) labels Mar 17, 2024
@eric-wieser eric-wieser mentioned this issue Mar 17, 2024
Closed
mathlib-bors bot pushed a commit that referenced this issue Mar 23, 2024
@eric-wieser
chore(GroupTheory): rename induction arguments for `Sub{semigroup,mon…
7339b9f 
…oid,group}` (#11461)

The additive version are still incorrectly named, but these can easily be tracked down later (#11462) by searching for `to_additive (attr := elab_as_elim)`.
utensil pushed a commit that referenced this issue Mar 26, 2024
@eric-wieser @utensil
chore(GroupTheory): rename induction arguments for `Sub{semigroup,mon…
4956531 
…oid,group}` (#11461)

The additive version are still incorrectly named, but these can easily be tracked down later (#11462) by searching for `to_additive (attr := elab_as_elim)`.
Louddy pushed a commit that referenced this issue Apr 15, 2024
@eric-wieser @Louddy
chore(GroupTheory): rename induction arguments for `Sub{semigroup,mon…
75621e7 
…oid,group}` (#11461)

The additive version are still incorrectly named, but these can easily be tracked down later (#11462) by searching for `to_additive (attr := elab_as_elim)`.
atarnoam pushed a commit that referenced this issue Apr 16, 2024
@eric-wieser @atarnoam
chore(GroupTheory): rename induction arguments for `Sub{semigroup,mon…
7bd0d1c 
…oid,group}` (#11461)

The additive version are still incorrectly named, but these can easily be tracked down later (#11462) by searching for `to_additive (attr := elab_as_elim)`.
uniwuni pushed a commit that referenced this issue Apr 19, 2024
@eric-wieser @uniwuni
chore(GroupTheory): rename induction arguments for `Sub{semigroup,mon…
fb6868c 
…oid,group}` (#11461)

The additive version are still incorrectly named, but these can easily be tracked down later (#11462) by searching for `to_additive (attr := elab_as_elim)`.
callesonne pushed a commit that referenced this issue Apr 22, 2024
@eric-wieser @callesonne
chore(GroupTheory): rename induction arguments for `Sub{semigroup,mon…
2399a95 
…oid,group}` (#11461)

The additive version are still incorrectly named, but these can easily be tracked down later (#11462) by searching for `to_additive (attr := elab_as_elim)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-algebra Algebra (groups, rings, fields etc) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eric-wieser