Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate signs #7842

Open
2 tasks
urkud opened this issue Oct 22, 2023 · 2 comments
Open
2 tasks

Deduplicate signs #7842

urkud opened this issue Oct 22, 2023 · 2 comments

Comments

@urkud
Copy link
Member

urkud commented Oct 22, 2023

We have SignType.sign, Int.sign, and Real.sign.
Probably, we should deduplicate them.

  • Replace Int.sign (see loogle) with SignType.sign.
  • Replace Real.sign (see loogle) with SignType.sign.
@loefflerd
Copy link
Collaborator

See my comments on #10883: we cannot replace Int.sign with anything derived from SignType.sign, since Int.sign is in std, not in mathlib.

@urkud
Copy link
Member Author

urkud commented Apr 21, 2024

We can backport SignType.sign to Std, if

  • we replace [Preorder α] with [LT α], and
  • we change from →o to .

OTOH, I don't know if it will be accepted in Std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants