Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yasnippet-lean.el): drop custom keybindings #3

Merged
merged 1 commit into from
May 26, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented May 26, 2020

I have 3 reasons to remove them:

  • yasnippet has other keybindings for these functions and I assume that packages should not change keybindings of other packages;
  • these bindings conflict with the default "search" (C-s) key binding in Emacs;
  • it's easy to add these keybindings back in ~/.emacs.d/init.el.

Yasnippet has other keybindings for these functions and these bindings conflict with the default "search" (`C-s`) key binding in Emacs.
@cipher1024 cipher1024 merged commit e0933f5 into master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants