Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo #5

wants to merge 1 commit into from

Conversation

pchaigno
Copy link

No description provided.

@pchaigno
Copy link
Author

@soonhokong Did you get a chance to look into this?

@soonho-tri
Copy link

@pchaigno , I'm not sure that pattern is a typo of patterns given https://github.com/leanprover/lean/search?l=Lean&q=pattern&type=&utf8=%E2%9C%93.

@pchaigno
Copy link
Author

pattern is the key in the Sublime Text grammar format here, not a Lean keyword.

@soonho-tri
Copy link

Ah, I see. Sounds good to me then. @leodemoura , could you merge this PR?

@leodemoura
Copy link
Member

@soonho-tri Thanks for looking into this stuff.

@pchaigno I will merge this PR later (not in the next few weeks). I am currently busy, and I don't like to merge PRs without testing them.

@pchaigno
Copy link
Author

pchaigno commented Jan 6, 2018

@leodemoura Did you get a chance to test this pull request?

@pchaigno
Copy link
Author

This typo is currently resulting in an error at grammar compilation for GitHub.com (see github-linguist/linguist#3924 for further details). @leodemoura @soonhokong Did one of you find time to look into this?

PS: The online Lightshow app may help if you need to run quick tests but don't have TextMate at hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants