Remove Unicode dependency to avoid large downloads for mathlib4 users #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Feb 5, 2023
| charInGeneralCategory c GeneralCategory.punctuation || | ||
| charInGeneralCategory c GeneralCategory.separator || | ||
| charInGeneralCategory c GeneralCategory.other | ||
| false -- TODO: restore the behavior described in the docstring |
There was a problem hiding this comment.
c == " " is probably a marginally better choice
|
Do you want to make the mentioned change in the comment or shall I go ahead and merge it? |
|
CI fails so I would recommend against merging this! |
|
Oh I was thinking this is just the usual CI fail from mathlib4 and std4 incompatability /o\ |
hargoniX
force-pushed
the
main
branch
4 times, most recently
from
b910c11
to
0c41523
Compare
|
Isn't this mostly fixed by 5f59fba |
|
It's definitely a great improval yes, I'll close the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until
lakelearns to not download this, I would claim that the benefit of marginally-nicer URLs is not worth the cost of having every mathlib4 user download a large archive of unicode data.