Fix finding on latest elan version in elan-init.sh. #74
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
May 3, 2022
| local _latest=$(ensure curl -sSf "$ELAN_UPDATE_ROOT/latest" | cut -d'"' -f2 | awk -F/ '{print $NF}') | ||
| local _latest=$(ensure curl -Ls -o /dev/null -w %{url_effective} "$ELAN_UPDATE_ROOT/latest" | cut -d'"' -f2 | awk -F/ '{print $NF}') |
There was a problem hiding this comment.
It seems like just adding L is enough to fix this? The -w flag seems pointless to me in the presense of -o /dev/null, and it's not clear to me that dropping S and f is beneficial.
(I'm using https://explainshell.com/explain?cmd=curl+-LsSf+-o+%2Fdev%2Fnull+-w+%25%7Burl_effective%7D for reference)
There was a problem hiding this comment.
It seems like just adding
Lis enough to fix this?
It doesn't for me. We want the redirection URL, not its content.
There was a problem hiding this comment.
and it's not clear to me that dropping
Sandfis beneficial.
I agree, though it's not terribly helpful without -o pipefail
|
Thanks for the analysis and fix, I pushed it as c586599. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #73