Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Recent bug fixes exposed a problem here. The field `resolveProvider?` has a `?`, but is not an `Option` type. The `ToJson` makes this assumption and uses the auxiliary function `opt`. The bugs fixed today were masjing this problem.
- Loading branch information
1 parent
f555610
commit 83b83f5
Showing
1 changed file
with
58 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83b83f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kha Could you please take a look at this fix? I am not familiar with the
ToJon
code generator, but as far as I can tell, it assumes a field containing a?
must haveOption
type.BTW, I am pushing another commit to fix the indentation. I am guessing my Emacs converted tab's into spaces when I saved the file.
83b83f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. The correct translation would be
resolveProvider? : Option Bool
, but this one works just as well (since we only send it, not parse it). And I must have accidentally copied the tabs from the LSP spec.