Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Incorrect path of the generated binary by lake in documentation #3094

Closed
lu-bulhoes opened this issue Dec 19, 2023 · 0 comments · Fixed by #3093
Closed

RFC: Incorrect path of the generated binary by lake in documentation #3094

lu-bulhoes opened this issue Dec 19, 2023 · 0 comments · Fixed by #3093
Labels
RFC Request for comments

Comments

@lu-bulhoes
Copy link
Contributor

Proposal

In the Lean Manual, section "Extended Setup Notes", we have the path of builded binary pointed to "./build/bin/foo" but this is an incorrect path. The generated binary stay in "./lake/build/bin/foo".

  • User Experience: This feature can help new lean users to better understand the setup environment.

  • Beneficiaries: beginners

  • Maintainability: No

Community Feedback

Ideas should be discussed on the Lean Zulip prior to submitting a proposal. Summarize all prior discussions and link them here.

Impact

Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.
@lu-bulhoes lu-bulhoes added the RFC Request for comments label Dec 19, 2023
@lu-bulhoes lu-bulhoes mentioned this issue Dec 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2023
@lu-bulhoes
fix: fixing path of the generated binary in documentation (#3093)
312ea12 
This PR fixes the documentation error in "Extended Setup Notes", where
the path of builded binary is pointed to
`./build/bin/foo`, but the truly path is `./lake/build/bin/foo`.

---

Closes #3094 (`RFC` or `bug` issue number fixed by this PR, if any)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Request for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixing path of the generated binary in documentation lu-bulhoes/lean4
1 participant
@lu-bulhoes