Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC(lake): Do not include missing files in Some builds logged failures #4256

Open
YaelDillies opened this issue May 23, 2024 · 0 comments
Open
Assignees
Labels
Lake Lake related issue RFC Request for comments

Comments

@YaelDillies
Copy link

Proposal

Thanks to #4115, #3809 is solved! This is great, except that I noticed some rough edges in the new grouping. Here's one:

When running lake build in MyProject, the log ends with something like this:

Some builds logged failures:
- DependencyProject.Foo
- MyProject.Bar
- MyProject

I would hope this list is the list of files I need to fix. However, DependencyProject.Foo is not part of my project and does not even exist. The reason it's included in the list is because MyProject.Bar tries to import DependencyProject.Foo, but this information is already available to me via MyProject.Bar being in the list.

It's important that the output of lake build clearly pinpoints where the errors are, as this is what users like me look at to fix the build.

Community Feedback

Zulip

Impact

Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.

@YaelDillies YaelDillies added the RFC Request for comments label May 23, 2024
@semorrison semorrison added bug Something isn't working Lake Lake related issue and removed RFC Request for comments labels May 23, 2024
@tydeu tydeu added RFC Request for comments and removed bug Something isn't working labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lake Lake related issue RFC Request for comments
Projects
None yet
Development

No branches or pull requests

3 participants