refactor: lake: import errors, job captions, log grouping #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 9, 2024
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 10, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 10, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 10, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2024
tydeu
changed the title
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 10, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 13, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 13, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 13, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 13, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.8.0 releases/v4.8.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.8.0
# Create a new branch
git switch --create backport-4115-to-releases/v4.8.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61a84c96db4ef76ebcd7b1510c5b7c7f1cf81212
# Push it to GitHub
git push --set-upstream origin backport-4115-to-releases/v4.8.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.8.0Then, create a pull request where the |
tydeu
added a commit
to tydeu/lean4
that referenced
this pull request
May 14, 2024
…#4115) This improves job captions, the grouping of logs underneath them, and the handling of import errors. It also adds a number of log-related utilities to help achieve this. **Key Changes:** * Job captions for facets now include the name of the object (e.g., module, library, facet). A caption has also been added to the top-level build of imports (e.g., for the server and `lake lean`). * Stray I/O and errors outside the build job in a build function captioned with `withRegisterJob` (e.g., user-defined targets) will now be properly grouped under that caption instead of ending up under "Computing build jobs". Stray I/O will be converted to a single informational log entry. * Builds no longer fail immediately on erroneous imports. Lake will now attempt to recover as best as possible from any import errors. Information on the import error will appear both in the build of the erroneous import and in the files which transitive import it. For example, uf `Lib.B` imports a missing module `Lib.A`, then the build of `Lib.A` will mention that the file does not exist, and the build of `Lib.B` will mention the bad import of `Lib.A`. Closes leanprover#3351. Closes leanprover#3809. (cherry picked from commit 61a84c9)
tydeu
added a commit
to tydeu/lean4
that referenced
this pull request
May 14, 2024
…#4115) This improves job captions, the grouping of logs underneath them, and the handling of import errors. It also adds a number of log-related utilities to help achieve this. **Key Changes:** * Job captions for facets now include the name of the object (e.g., module, library, facet). A caption has also been added to the top-level build of imports (e.g., for the server and `lake lean`). * Stray I/O and errors outside the build job in a build function captioned with `withRegisterJob` (e.g., user-defined targets) will now be properly grouped under that caption instead of ending up under "Computing build jobs". Stray I/O will be converted to a single informational log entry. * Builds no longer fail immediately on erroneous imports. Lake will now attempt to recover as best as possible from any import errors. Information on the import error will appear both in the build of the erroneous import and in the files which transitive import it. For example, uf `Lib.B` imports a missing module `Lib.A`, then the build of `Lib.A` will mention that the file does not exist, and the build of `Lib.B` will mention the bad import of `Lib.A`. Closes leanprover#3351. Closes leanprover#3809. (cherry picked from commit 61a84c9)
tydeu
added a commit
to tydeu/lean4
that referenced
this pull request
May 14, 2024
…#4115) This improves job captions, the grouping of logs underneath them, and the handling of import errors. It also adds a number of log-related utilities to help achieve this. **Key Changes:** * Job captions for facets now include the name of the object (e.g., module, library, facet). A caption has also been added to the top-level build of imports (e.g., for the server and `lake lean`). * Stray I/O and errors outside the build job in a build function captioned with `withRegisterJob` (e.g., user-defined targets) will now be properly grouped under that caption instead of ending up under "Computing build jobs". Stray I/O will be converted to a single informational log entry. * Builds no longer fail immediately on erroneous imports. Lake will now attempt to recover as best as possible from any import errors. Information on the import error will appear both in the build of the erroneous import and in the files which transitive import it. For example, uf `Lib.B` imports a missing module `Lib.A`, then the build of `Lib.A` will mention that the file does not exist, and the build of `Lib.B` will mention the bad import of `Lib.A`. Closes leanprover#3351. Closes leanprover#3809. (cherry picked from commit 61a84c9)
semorrison
pushed a commit
that referenced
this pull request
May 15, 2024
This improves job captions, the grouping of logs underneath them, and the handling of import errors. It also adds a number of log-related utilities to help achieve this. **Key Changes:** * Job captions for facets now include the name of the object (e.g., module, library, facet). A caption has also been added to the top-level build of imports (e.g., for the server and `lake lean`). * Stray I/O and errors outside the build job in a build function captioned with `withRegisterJob` (e.g., user-defined targets) will now be properly grouped under that caption instead of ending up under "Computing build jobs". Stray I/O will be converted to a single informational log entry. * Builds no longer fail immediately on erroneous imports. Lake will now attempt to recover as best as possible from any import errors. Information on the import error will appear both in the build of the erroneous import and in the files which transitive import it. For example, uf `Lib.B` imports a missing module `Lib.A`, then the build of `Lib.A` will mention that the file does not exist, and the build of `Lib.B` will mention the bad import of `Lib.A`. Closes #3351. Closes #3809. (cherry picked from commit 61a84c9)
semorrison
pushed a commit
that referenced
this pull request
May 21, 2024
This improves job captions, the grouping of logs underneath them, and the handling of import errors. It also adds a number of log-related utilities to help achieve this. **Key Changes:** * Job captions for facets now include the name of the object (e.g., module, library, facet). A caption has also been added to the top-level build of imports (e.g., for the server and `lake lean`). * Stray I/O and errors outside the build job in a build function captioned with `withRegisterJob` (e.g., user-defined targets) will now be properly grouped under that caption instead of ending up under "Computing build jobs". Stray I/O will be converted to a single informational log entry. * Builds no longer fail immediately on erroneous imports. Lake will now attempt to recover as best as possible from any import errors. Information on the import error will appear both in the build of the erroneous import and in the files which transitive import it. For example, uf `Lib.B` imports a missing module `Lib.A`, then the build of `Lib.A` will mention that the file does not exist, and the build of `Lib.B` will mention the bad import of `Lib.A`. Closes #3351. Closes #3809. (cherry picked from commit 61a84c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves job captions, the grouping of logs underneath them, and the handling of import errors. It also adds a number of log-related utilities to help achieve this.
Key Changes:
Job captions for facets now include the name of the object (e.g., module, library, facet). A caption has also been added to the top-level build of imports (e.g., for the server and
lake lean).Stray I/O and errors outside the build job in a build function captioned with
withRegisterJob(e.g., user-defined targets) will now be properly grouped under that caption instead of ending up under "Computing build jobs". Stray I/O will be converted to a single informational log entry.Builds no longer fail immediately on erroneous imports. Lake will now attempt to recover as best as possible from any import errors. Information on the import error will appear both in the build of the erroneous import and in the files which transitive import it. For example, uf
Lib.Bimports a missing moduleLib.A, then the build ofLib.Awill mention that the file does not exist, and the build ofLib.Bwill mention the bad import ofLib.A.Closes #3351. Closes #3809.